search

oracle / odpi

ODPI-C: Oracle Database Programming Interface for Drivers and Applications
https://oracle.github.io/odpi/
Other
264 stars 75 forks source link

Docs updates according to internal requirements #183

Closed spavlusieva closed 1 month ago

spavlusieva commented 10 months ago

Sorry, Pull Requests for ODPI-C cannot be accepted. Please report bugs and ask questions using GitHub issues https://github.com/oracle/odpi/issues

LesiaChaban commented 2 months ago

Hello @cjbj , could you please review and approve this PR if this acceptable for you? I have reverted changes to the CONTRIBUTING.md

cjbj commented 2 months ago

Did you still mean to keep .github/SECURITY.md as well as the new file?

LesiaChaban commented 2 months ago

The GCAS tool only scans SECURITY.md in the root folder, so there is no need to leave it in .github/

cjbj commented 2 months ago

@LesiaChaban Am I mis-reading the PR changes? I didn't see the original file being removed/moved.

LesiaChaban commented 2 months ago

I reverted the commit that made changes to the CONTRIBUTING file, then rebase the commits into one. This PR create changes just to README and add SECURITY.md to the root folder now. The repository still won't pass template check, but it's very important for us to have a SECURITY.md file in the repository

cjbj commented 2 months ago

I think we agree we don't need two SECURITY files. Can you remove one or the other in this PR?

LesiaChaban commented 2 months ago

Sure, I will remove .github/SECURITY.md

LesiaChaban commented 2 months ago

DONE

LesiaChaban commented 1 month ago

Hi @cjbj, could you please review my latest changes and merge this PR if possible?

LesiaChaban commented 1 month ago

Hi @cjbj, I added changes to the SECURITY file, please feel free to change this security section as it suit you

cjbj commented 1 month ago

Hi @cjbj, I added changes to the SECURITY file, please feel free to change this security section as it suit you

I've merged it to our internal, working repo. The next sync to GH will push the changes here.