search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.36k stars 748 forks source link

Active links from the changeset info window #1367

Open jfriedel opened 7 years ago

jfriedel commented 7 years ago

The links otherwise available from the history page of a file in the repo (e.g. links to architecture review cases, or links to bug databases) should be available also from the the window showing up in the changeset info window (annotation: ON).

active_links

tulinkry commented 7 years ago

This also requires that the tooltip must be accessible with mouse (which is not now)

vladak commented 7 years ago

Like with #1366 , the idea of hunting for the tooltip with mouse is not very intriguing to me, to say the least.

jfriedel commented 7 years ago

"hunting for the tooltip"?.. Anyway, how about an alternate solution -- is there a way of how to get quickly to the history page of the given file and land on the that page on the given changeset? That said, instead of remembering the changeset id, then going to the history page and looking up that changeset id on that page, one would be able to quickly get to the given line on the history page. On the history page, the links already work.

vladak commented 7 years ago

you mean the link name ? that already works, e.g. https://grok/source/history/opengrok-master/src/org/opensolaris/opengrok/index/Indexer.java#b528c008

jfriedel commented 7 years ago

Yes, but how to get quickly from a source page with annotation on to the respective line on the history page? I.e. how to quickly get

from here: https://grok/source/xref/opengrok-master/src/org/opensolaris/opengrok/index/Indexer.java?a=true to here: https://grok/source/history/opengrok-master/src/org/opensolaris/opengrok/index/Indexer.java?n=25&start=50#5e6c91d7 (note: see that this is not the first history page..)