oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.35k stars 749 forks source link

weird behavior when project is listed under more than one group #2626

Open kkarczew opened 5 years ago

kkarczew commented 5 years ago

When a project is listed in more than one category, making it appear multiple times in a project list, selecting it causes multiple 'selected project' frames to appear. This by itself is a minor annoyance, but it has an interesting side effect. If such a project is selected together with another one, and a search is run, it's not possible to remove the multiply-listed project from the results list - once the cross is clicked in the frame to remove it, the page refreshes, and the removed frame reappears, since the project is still selected via the second entry on the list.

A workaround for this issue is to use the project list to unselect the unwanted entry - unchecking entries on the list does not trigger a refresh, so the auto-reselection is not triggered.

This is reproducible on OpenGrok 1.1.2, but I believe the part with project listed multiple times triggering multiple 'selected project' frames is present for a long time - I've seen it before the search page was adjusted to auto-refresh on selection change, but at that time it was just a minor annoyance, and the project list was adjusted shortly, making the issue disappear.

tulinkry commented 5 years ago

related to #1576

vladak commented 5 years ago

is this a dup then ?

tulinkry commented 5 years ago

No, it depends on fixing the #1576 bug first.