search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.34k stars 745 forks source link

IE10 js error #2694

Closed Teriand closed 5 years ago

Teriand commented 5 years ago

opengrok 1.2.2

  1. Object doesn't support property or method 'includes' - utils-0.0.29.js:1787
  2. Object doesn't support property or method "startsWith" - utils-0.0.29.js:1868
  3. Object doesn't support property or method "isInteger" - utils-0.0.29.js:1772
ahornace commented 5 years ago

Honestly, do we want to support IE?

Teriand commented 5 years ago

very small changes for support. and in Enterprise IE10/11 its LTS

No one know when microsoft real change engine to chrome.

tulinkry commented 5 years ago

I agree, this little change does not cost anything.

ahornace commented 5 years ago

I think this just prevents us from moving forward innovatively and we would sign up for something we don't really want.

https://mashable.com/article/microsoft-stop-using-internet-explorer-browser/?europe=true

tulinkry commented 5 years ago

This three line change does not prevent anything. Moving forward with our javascript is a whole another story.

ahornace commented 5 years ago

So if someone makes other JS changes and they break IE support then it's okay?

IE is past.

Teriand commented 5 years ago

if break, we have chance fix it.

ahornace commented 5 years ago

But tell me a reason why. Why cannot we use something so trivial as startsWith and have a nice clean code just because some very very small percentage of people is still using obsolete software?

This just makes the maintaining harder.

How many Android developers support 2.x ?

tulinkry commented 5 years ago

Because it's costless to keep supporting this obsolete software at this point. If you were to develop a feature which violates it, then yeah, let's do it with a clean code.

ahornace commented 5 years ago

If you were to develop a feature which violates it, then yeah, let's do it with a clean code.

That's what I wanted to hear.