search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.36k stars 748 forks source link

Home page project links missing webapp name #2802

Closed cross closed 5 years ago

cross commented 5 years ago

Running a fairly recent build from head (1.2.9), I have found that the links to projects at the top-level web page do not include the web app name.

My app is reached at http://localhost:8080/source/, and there are two projects/repositories listed in the table below the search input fields. Each of these links to http://localhost:8080/xref/projectA, which doesn't work. The correct href should be http://localhost:8080/source/xref/projectA, which works when I manually adjust the URL.

I think these links used to be correct, and that I have used them before, but I cannot verify that at the moment.

Is this a tomcat config issue, or something wrong in opengrok?

vladak commented 5 years ago

possibly related to #2719

vladak commented 5 years ago

I can confirm - seeing the same.

IamTHEvilONE commented 5 years ago

I'm still seeing this issue on 1.2.14 after upgrading, deploying the new WAR, and cleaning out the indexes and re-indexing (to push the new config).

The html code after generation looks like this:

<td class="name repository">
<a href="/xref/version"
 title="Xref for project version">
version
 </a>

so it's still not pulling the webapp name into it.

vladak commented 5 years ago

Looks like while request is implicit variable in JSP, it is not in JSTL: http://www.informit.com/articles/article.aspx?p=30946&seqNum=7

cross commented 5 years ago

Thank you @IamTHEvilONE . I was also still seeing it, but hadn't gotten to verifying that I'd cleared and flushed everything until today. This issue should be reopened, @vladak ? Hmm. I guess until 3af6c7cd1802b84919948fd09d3622ecc50d9f17 is committed and verified...

vladak commented 5 years ago

Good question @cross, there does not seem to be established process for such case. Let's keep this simple for now.

IamTHEvilONE commented 5 years ago

Just commenting that this is fixed in release 1.2.16 when I was testing the build.