search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.34k stars 745 forks source link

Merged text after adding OpenGrok logo to header #3452

Closed chkp-baselz closed 3 years ago

chkp-baselz commented 3 years ago

I have added to pageheader.jspf OpenGrok logo to easily return home, but I have this merged text in any source, (merging of list details and menu), could you please tell me where to add an empty div to resolve this? image

this line have been add to pageheader.jspf <a href="<%= request.getContextPath() %>/"><span id="MastheadLogo"></span></a>

I have added the logo because it's easier and users are regular for all websites to click on the logo to go back to the homepage, so I suggest adding it into new versions.

vladak commented 3 years ago

Changing the JSP files is not recommended/supported. If you want to insert anything into the header/footer, use the include files as documented on https://github.com/oracle/opengrok/wiki/Webapp-configuration#include-files

As for changing the default pages to include the logo also at the top: we strive to keep the UI as minimal as possible so that will not likely happen. There is the 'Home' link that can take users to the index page.

chkp-baselz commented 3 years ago

@vladak thnx for your help but it didn't help, the text still merging

vladak commented 3 years ago

Don't have any advice right now besides exploring the existing HTML layout. I remember @blu28 was trying to achieve something similar in the past.

chkp-baselz commented 3 years ago

@vladak yes I have fixed it by exploring the HTML and editing it and CSS

Thank you

blu28 commented 3 years ago

This problem always seems like it is a flaw in the CSS layout of the page. I don't know enough CSS to fix it though. My son probably does, I will see if I can get him to take a look.

chkp-baselz commented 3 years ago

@blu28 I think I have fixed it under CSS also thank you, I could share my solution if needed.

blu28 commented 3 years ago

Please.

Sent from my iPhone

On Mar 12, 2021, at 4:40 PM, baselz324 @.***> wrote:

 @blu28 I think I have fixed it under CSS also thank you, I could share my solution if needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.