smarter filename matching for xrefs

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java

http://oracle.github.io/opengrok/

Other

4.33k stars 746 forks source link

smarter filename matching for xrefs #3643

Open ahornace opened 3 years ago

ahornace commented 3 years ago

suggester.ini is presented as a clickable link but does not produce any results:

http://demo.opengrok.org/xref/OpenGrok/suggester/src/main/java/org/opengrok/suggest/Suggester.java?r=b13c5a0e#157

vladak commented 3 years ago

I think the substring of "suggester.init.latency" was matched because it resembles a path name.

vladak commented 3 years ago

Not sure this is actually a bug or what is the actual desired outcome.

ahornace commented 3 years ago

I think this is definitely a bug. Why a random substring which just resembles a filename should be displayed as an invalid link when there is no match for it? suggester.ini is actually not even a proper group of terms in this case.

vladak commented 3 years ago

The filename matching needs to be a lot smarter then.