search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.29k stars 739 forks source link

opengrok-indexer seems to set commons-io:commons-io in the wrong scope. #4471

Closed HappyHacker123 closed 8 months ago

HappyHacker123 commented 8 months ago

Describe the bug Dependency commons-io:commons-io in opengrok-indexer is set to the default dependency scope "compile". However, it seems that it's only used for tests with class org.apache.commons.io.FileUtils.

To Reproduce It's easy to confirm in latest opengrok-indexer/pom.xml.

Expected behavior The dependency scope of commons-io should be set to test according to maven's doc on dependency scope.

Additional Context I change the dependency scope to test and recompile the module. The module is successfully compiled, meaning the dependency is indeed not a compile scope dependency. Considering it's used in tests only, test scope would be the appropriate scope.

HappyHacker123 commented 8 months ago

I opened a pr related to this issue. Could you help me review this issue @vladak ? Thx :)