search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.29k stars 739 forks source link

Sonar code smell fixes in web package #4512

Closed ginoaugustine closed 4 months ago

ginoaugustine commented 7 months ago
  1. Created a new Builder for search helper class and used that for created search helper instance( This was done to reduce number of parameters passed to constructor)
  2. Reduced complexity of methods in search helper and utl classes
ginoaugustine commented 4 months ago

Removed double prefix and added a UT class to test these changes

vladak commented 4 months ago

Also, some level of UI testing would be useful for this change, I believe. In particular of the slider for the search results.