search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.29k stars 739 forks source link

Remove helix-p4d from install list #4520

Closed parheliamm closed 6 months ago

parheliamm commented 6 months ago

helix-p4d didn't available on ARM64 platform, there is no obvious impacts after checking docker image on ARM64

After this change, docker image created successfully on ARM64 platform.

oracle-contributor-agreement[bot] commented 6 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

parheliamm commented 6 months ago

This will remove Perforce from x86 image, though. Is there a way how to make it optional ?

The new patches detect the architecture during docker image build stage. If ARM64 found, skip install helix-p4d only.

vladak commented 6 months ago

Ack, need to have your OCA on file before this can go in.

parheliamm commented 6 months ago

Ack, need to have your OCA on file before this can go in.

OCA is under reviewing, it might be passed in coming days.

oracle-contributor-agreement[bot] commented 6 months ago

Thank you for signing the OCA.

vladak commented 6 months ago

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

parheliamm commented 6 months ago

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

Do I need to check the the failure issue and fix it?

vladak commented 6 months ago

Seems like the Docker image linter complains about the multiple RUNs. The error can be suppressed.

Do I need to check the the failure issue and fix it?

yes, the build has to be clean for this to get in.

vladak commented 6 months ago

Thanks !