search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.35k stars 745 forks source link

Fix `READONLY_CONFIG_FILE` configurations not being merged #4522

Closed MasterAwesome closed 9 months ago

MasterAwesome commented 9 months ago

When READONLY_CONFIG_FILE is used, the file name passed to merge_config_files is the object as a string which is serialized and written into disk. This always results in a file named <tempfile._TemporaryFileWrapper object at 0x7fa12bf82350> on disk instead of the actual name and doesn't actually merge configs.

oracle-contributor-agreement[bot] commented 9 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.