oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.35k stars 745 forks source link

`READONLY_CONFIG_FILE` doesn't work in docker containers #4523

Closed MasterAwesome closed 8 months ago

MasterAwesome commented 9 months ago

When READONLY_CONFIG_FILE is used, the file name passed to merge_config_files is the object as a string which is serialized and written into disk. This always results in a file named <tempfile._TemporaryFileWrapper object at 0x7fa12bf82350> on disk instead of the actual name and doesn't actually merge configs.

Bug is present in master branch of opengrok

To Reproduce

Expected behavior Merging configs succeeds

Observed behavior Merging configs uses the object instead of the actual FS path <tempfile._TemporaryFileWrapper object at 0x7fa12bf82350> resulting in merge failure + read-only-config to not be applied.

vladak commented 8 months ago

This was introduced with the rework of how config merge is called (#4509).