search

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java
http://oracle.github.io/opengrok/
Other
4.34k stars 745 forks source link

the width of search fields on the frontpage should not be hardcoded (Bugzilla #5880) #598

Closed vladak closed 5 years ago

vladak commented 11 years ago

status NEW severity minor in component webapp for --- Reported in version unspecified on platform Other Assigned to: Trond Norbye

On 2008-12-17 08:26:34 +0000, Vladimir Kotal wrote:

The size of the search fields is hardcoded in web/menu.jspf to 300 pixels: 


     30                     <tr><td align="right"> Full&nbsp;Search </td><td><input class="q" name="q" size="45" style="width: 300px" value="<%=Util.formQuoteEscape(q)%>"/></td></tr>
     31                     <tr><td align="right"> Definition </td><td><input class="q" name="defs" size="25" style="width: 300px" value="<%=Util.formQuoteEscape(defs)%>"/></td></tr>
     32                     <tr><td align="right"> Symbol </td><td><input class="q" name="refs" size="25" style="width: 300px" value="<%=Util.formQuoteEscape(refs)%>"/></td></tr>
     33                     <tr><td align="right"> File&nbsp;Path </td><td><input class="q" name="path" size="25" style="width: 300px" value="<%=Util.formQuoteEscape(path)%>"/></td></tr>
     34                     <tr><td align="right"> History </td><td><input class="q" name="hist" size="25" style="width: 300px" value="<%=Util.formQuoteEscape(hist)%>"/></td></tr>
     35                     <% if (hasProjects) { %>
     36                     <tr>
     37                         <td align="right" valign="top"> Project </td>
     38                         <td>
     39                             <select class="q" name="project" size="<%=Math.min(5, env.getProjects().size())%>" style="width: 300px">

Instead, it should be part of the CSSs.

tulinkry commented 5 years ago

If I remember correctly now the search fields are 100% of the 30% box.

vladak commented 5 years ago

I don't see the hard-coded pixels in menu.jspf any more.