Favicon shows Tomcat-icon when GET-param "h=#" is added

oracle / opengrok

OpenGrok is a fast and usable source code search and cross reference engine, written in Java

http://oracle.github.io/opengrok/

Other

4.34k stars 745 forks source link

Favicon shows Tomcat-icon when GET-param "h=#" is added #813

Open kosi2801 opened 10 years ago

kosi2801 commented 10 years ago

The default OpenGrok-favicon is not displayed, when the browser is (re-)directed to a file-display page with the GET-parameter "h=#".

For example displaying a file with xref http://server.localhost:8080/source/xref/project1/File1.java shows the default OpenGrok icon. But if the "Annotate" link in the header is clicked, the browser is redirected to http://server.localhost:8080/source/xref/project1/File1.java?a=true&h=# and the tab icon shows the Tomcat-animal.

vladak commented 9 years ago

I checked and the behavior differs across browsers (tested on Win 7):

Chrome 41.0.x: no problem at all
Firefox 33.0.3: Annotate view has wrong favicon
IE 11.0.9600.x: all the views display wrong favicon

vladak commented 9 years ago

The alternate favicon is displayed using the link tag:

<link rel="icon" href="<%=styleDir%>/img/icon.png" type="image/png" />

in httpheader.jspf.

Checking page source of all views it is present there. Looks like a browser bug to me however I am not entirely sure since there does not seem to be any way to debug this.

tarzanek commented 9 years ago

firebug won't help?

tarzanek commented 9 years ago

(or similar for other browsers)

vladak commented 9 years ago

tried Firebug just for the kicks, as far as I can tell there is nothing which can help there - can inspect page elements only. Also, the rather aggressive caching of favicon by FF hampers debugging.