search

oracle / oracle-database-operator

The Oracle Database Operator for Kubernetes (a.k.a. OraOperator) helps developers, DBAs, DevOps and GitOps teams reduce the time and complexity of deploying and managing Oracle Databases. It eliminates the dependency on a human operator or administrator for the majority of database operations.
Universal Permissive License v1.0
141 stars 45 forks source link

fix: panic on error #78

Closed tenstad closed 4 weeks ago

tenstad commented 11 months ago

Controller currently panics on error :/ due to invalid log format; specifically due to an odd number of key-value parameters in log.Error.

Copied the log format from log.Error(err, "Failed to update status for :"+pdb.Name, "err", err.Error()) above, although I don't really see why "err", err.Error() is needed in log.Error.

oracle-contributor-agreement[bot] commented 11 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

oracle-contributor-agreement[bot] commented 11 months ago

Thank you for signing the OCA.

mmalvezz commented 4 weeks ago

Issue has been fixed