search

oracle / oracle-r2dbc

R2DBC Driver for Oracle Database
https://oracle.com
Other
197 stars 40 forks source link

Consider adding META-INF/services/io.r2dbc.spi.ConnectionFactoryProvider #10

Closed mp911de closed 3 years ago

mp911de commented 3 years ago

Right now, the ServiceLoader information is only activated when using the module path. It would be nice to not be required to use Java Modules to use the driver (i.e being able to use classpath mode).

Michael-A-McMahon commented 3 years ago

Thanks, @mp911de. It should be the case that non-modular code bases are supported. I'll look into why this isn't working as intended.

FYI: A /services/io.r2dbc.spi.ConnectionFactoryProvider file is present: https://github.com/oracle/oracle-r2dbc/blob/main/src/main/resources/META-INF/services/io.r2dbc.spi.ConnectionFactoryProvider But I'm not sure sure why the ServiceLoader isn't recognizing it.

Michael-A-McMahon commented 3 years ago

I now see that our services directory is no longer included in our jars when we build with maven. Might be related to recent changes in pom.xml? I'll come back to this tomorrow.