search

oracle / python-oracledb

Python driver for Oracle Database conforming to the Python DB API 2.0 specification. This is the renamed, new major release of cx_Oracle
https://oracle.github.io/python-oracledb
Other
328 stars 66 forks source link

Enhance type hinting in the subscr module #54

Closed troyswanson closed 2 years ago

troyswanson commented 2 years ago

The subscr module defines classes related to CQN functionality. It would be really nice to see these classes fully decked out with type hints. Here are some ideas:

These enhancements would make working with subscription message objects much easier. Since there are several rows of nesting involved with interacting with the actual rows, it's sometimes hard to keep track of where we are 💫

Thanks for your consideration!

anthony-tuininga commented 2 years ago

This has been implemented and I went through the remaining code and looked for missing/invalid type hinting and corrected the ones I found. If you have any further ones that need implementing or enhancing, let me know! Thanks.

anthony-tuininga commented 2 years ago

Included in python-oracledb 1.1.1 which was just released.