search

oracle / railcar

RailCar: Rust implementation of the Open Containers Initiative oci-runtime
Other
1.12k stars 101 forks source link

Implement eq and as_str in LinuxCapabilityType #37

Open josselinchevalay opened 6 years ago

josselinchevalay commented 6 years ago

i created an issue https://github.com/oracle/railcar/issues/36

for solved that i propose this pull request let me know your advice.

Regards

drahnr commented 5 years ago

Is anything blocking this right now?

vishvananda commented 5 years ago

I don't believe @josselinchevalay has signed the CLA so I can't merge. That said, I don't follow the updated logic. If difference is working properly, the if statement on the second line should always be false.

drahnr commented 5 years ago

I did not look into the code itself, just wondering why this is dangling :)

josselinchevalay commented 5 years ago

hi all,

yep second if statement seems return false always, i didn't why ? for CLA how to signed ?

Regards

vishvananda commented 5 years ago

Instructions and a link to the OCA info can be found on the contributing page:

https://github.com/oracle/railcar/blob/master/CONTRIBUTING.md

vishvananda commented 5 years ago

but yes i still don't think this new logic is correct.

drahnr commented 5 years ago

@josselinchevalay it's been a while, any news?

josselinchevalay commented 5 years ago

@drahnr nop i need to sign CLA. do you have same issue ?

drahnr commented 5 years ago

I already signed the CLA :)

josselinchevalay commented 5 years ago

ok for me that solved my issue with caps errors

drahnr commented 5 years ago

Could you add print statement and show the two prints of the old and new logic. I am not quite sure what should differ between both of them.