search

oracle / railcar

RailCar: Rust implementation of the Open Containers Initiative oci-runtime
Other
1.12k stars 101 forks source link

chore (edition 2018, Cargo.lock) #47

Open drahnr opened 5 years ago

drahnr commented 5 years ago

Superseeds changes from #46 and #44 - recreated changes since I already signed the CLA

vishvananda commented 5 years ago

looks like it needs a flag added to a crate to build on nightly From the wercker logs:

   Compiling strsim v0.8.0
   Compiling textwrap v0.11.0
error: use of unstable library feature 'ord_max_min' (see issue #25663)
   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/strsim-0.8.0/src/lib.rs:190:59
    |
190 |     1.0 - (levenshtein(a, b) as f64) / (a.chars().count().max(b.chars().count()) as f64)
    |                                                           ^^^
    |
    = help: add #![feature(ord_max_min)] to the crate attributes to enable

musl seems to be broken for unrelated reasons

drahnr commented 5 years ago

on my local machine nightly compiles just fine ( nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.37.0-nightly (8ebd67e4e 2019-06-27) ), the error message of the wercker build does complain about the same issue as with the first commit, but https://github.com/oracle/railcar/pull/47/commits/f7e9e9f85c9b922a53e88c6f6b0b16be512c03fb addresses that. Could you take a look at this?

drahnr commented 5 years ago

Ping

spacekookie commented 5 years ago

lol it's a bit ridiculous that instead of just merging existing PRs you replicate stuff in new ones

drahnr commented 5 years ago

lol it's a bit ridiculous that instead of just merging existing PRs you replicate stuff in new ones

I thought I expressed why this was done in the first place in the initial PR message - I signed the CLA, and I wanted to avoid low hanging fruits/chores being stalled by the lack of other people signing the CLA.

spacekookie commented 5 years ago

I thought I expressed why this was done in the first place in the initial PR message - I signed the CLA, and I wanted to avoid low hanging fruits/chore being stalled by the lack of other people signing the CLA.

Oh yea, you made that clear. It's just weird that other people who would like to contribute, who already made the changes aren't even being pinged about a CLA.