oracle / terraform-provider-oci

Terraform Oracle Cloud Infrastructure provider
https://www.terraform.io/docs/providers/oci/
Mozilla Public License 2.0
758 stars 676 forks source link

variables for node pool cycling are not the same in the markdown and examples #1961

Open rodrigc opened 1 year ago

rodrigc commented 1 year ago

Community Note

Terraform Version and Provider Version

Terraform v1.4.4
on darwin_amd64
+ provider registry.terraform.io/hashicorp/cloudinit v2.3.2
+ provider registry.terraform.io/hashicorp/helm v2.11.0
+ provider registry.terraform.io/hashicorp/http v3.4.0
+ provider registry.terraform.io/hashicorp/null v3.2.1
+ provider registry.terraform.io/hashicorp/random v3.5.1
+ provider registry.terraform.io/hashicorp/time v0.9.1
+ provider registry.terraform.io/oracle/oci v4.119.0

Affected Resource(s)

oci_containerengine_node_pool oci_containerengine_node_pool

Problem

On this line: https://github.com/oracle/terraform-provider-oci/blob/e812a7f05ea9e5f1c9a513feec586a1539816671/website/docs/r/containerengine_node_pool.html.markdown?plain=1#L82 there is a variable var.node_pool_node_pool_cycling_details_is_node_cycling_enabled

However, in the example here: https://github.com/oracle/terraform-provider-oci/blob/e812a7f05ea9e5f1c9a513feec586a1539816671/examples/container_engine/main.tf#L263 there is a variable: var.node_pool_cycling_details_is_node_cycling_enabled

These variables are different but referring to the same thing.

Please fix this so that the variables in the markdown and the variables in the examples are the same, and that everything actually works.

rodrigc commented 1 year ago

According to @robo-cap , there is a rule: {resource_name.replace('test_', '')}_{dynamic_block_name}_{attribute_name} which autogenerates variable names into markdown. This rule may be generating incorrect variables for node pool cycling

tf-oci-pub commented 1 year ago

Thank you for reporting the issue. We observed the affected resources are not provided in the description or it's incorrect. We request you to add it in issue description as mentioned in below format. Example: affected_resources = oci_core_instance , oci_core_instances

If it's not related to any particular resource then mention affected resource as terraform. Example: affected_resources = terraform

As this works through automation, request you to follow exact syntax.

rodrigc commented 1 year ago

I already specified in tthe description that oci_containerengine_node_pool is the affected resource. I don't know why tf-oci-pub didn't see this.