search

oracle / terraform-provider-oci

Terraform Oracle Cloud Infrastructure provider
https://www.terraform.io/docs/providers/oci/
Mozilla Public License 2.0
760 stars 683 forks source link

feat(core_public_ip): add the attachment resource #2203

Open NefixEstrada opened 1 month ago

NefixEstrada commented 1 month ago

This resource enables the Public IP attachment / deattachment, independently from the actual IP addresses This solves the issue when you need to use an already existing IP address, that was created outside from Terraform

Closes #1565 #1802

oracle-contributor-agreement[bot] commented 1 month ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

tf-oci-pub commented 1 month ago

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

DavidChamardGoto commented 1 week ago

We are very interested in this feature. Any plan to review it soon?

NefixEstrada commented 1 week ago

@DavidChamardGoto we've running this in production for a while and it's working correctly