oracle / tribuo

Tribuo - A Java machine learning library
https://tribuo.org
Apache License 2.0
1.27k stars 175 forks source link

Refactor changes to improve code readability #336

Closed prasanth08 closed 1 year ago

prasanth08 commented 1 year ago

Description

Removed null checks before checking instanceof as null case is handled. Reorder Access modifiers as per JSR standard Use of lambda expression to improve readability.

Motivation

Refactor changes to improve code readability.

Craigacp commented 1 year ago

The null checks & access modifier reorderings are fine, but please don't modify the generated protobuf code (anything in a protos package) as those changes will be overwritten when we regenerate the protobufs as we change protobuf-java versions. In general we leave the public modifier in interfaces to make it explicit even for default methods, so don't remove that either.

prasanth08 commented 1 year ago

Got it! Made those changes.

Craigacp commented 1 year ago

Thanks for the contribution.