Thread.new should inherit the interrupt mask of the calling thread

oracle / truffleruby

A high performance implementation of the Ruby programming language, built on GraalVM.

https://www.graalvm.org/ruby/

Other

3.03k stars 185 forks source link

Thread.new should inherit the interrupt mask of the calling thread #1447

Open larskanis opened 6 years ago

larskanis commented 6 years ago

This was recently fixed in JRuby here: https://github.com/jruby/jruby/issues/5314 . It would be nice to get this fixed in Truffleruby as well. Until then I use the following workaround for Eventbox.

chrisseaton commented 6 years ago

The 'interrupt mask' is the thing that handle_interrupt sets, is that right? It's not about signal masks of the underlying threads or anything like that?

larskanis commented 6 years ago

Exactly, the thing that handle_interrupt sets. Since it can not mask anything other than Exceptions for now, it has nothing to do with signals. See also my comment here: https://github.com/jruby/jruby/issues/5314#issuecomment-426713442