search

oracle / truffleruby

A high performance implementation of the Ruby programming language, built on GraalVM.
https://www.graalvm.org/ruby/
Other
3.02k stars 185 forks source link

truffle/truffle/fiddle_backend.rb may raise `Polyglot::ForeignException` #2714

Closed kou closed 2 years ago

kou commented 2 years ago

It should raise Fiddle::Error or Fiddle::DLError to compatible with https://github.com/ruby/fiddle .

e.g.:

https://github.com/ruby-gettext/locale/runs/8130975674?check_suite_focus=true#step:5:8

/Users/runner/.rubies/truffleruby-head/lib/truffle/truffle/fiddle_backend.rb:262:in `<unknown>': dlopen(kernel32.dll, 2): image not found (Polyglot::ForeignException)
eregon commented 2 years ago

Thank you for the report, I'll take a look soon.

eregon commented 2 years ago

There seems to be no test in Fiddle for this case. I guess I'll test this in ruby/spec then.

eregon commented 2 years ago

This is a regression since 22.1, it will be fixed soon.

eregon commented 2 years ago

@kou Could you maybe rerun https://github.com/ruby-gettext/locale/actions/runs/2970103655/jobs/4780349285 to check it works fine now?

kou commented 2 years ago

Done: https://github.com/ruby-gettext/locale/actions/runs/2970103655/jobs/4905290386 It's green now. :-) Thanks.

eregon commented 2 years ago

Great, thanks!