Add a commented-out option to allow a private network for PL/SQL debu…

oracle / vagrant-projects

Vagrant projects for Oracle products and other examples

Universal Permissive License v1.0

930 stars 473 forks source link

Add a commented-out option to allow a private network for PL/SQL debu… #486

Open CBatemanOracle opened 1 year ago

CBatemanOracle commented 1 year ago

…gging.

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

PR author: @CBatemanOracle

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

PaulNeumann commented 1 year ago

I like this idea, but I have a couple of comments.

If this is implemented, I think it should be done for all of the single instance database projects, not just 19.3.0.
I think it should be configured using environment variables (and, optionally, the vagrant-env plugin), to be consistent with the other configurable parameters, and to make it unnecessary to modify the Vagrantfile.
I don't think the 192.168 address range will work for the libvirt provider.
I think the README.md file should be updated to include this enhancement.