search

oracle / weblogic-azure

This project offers support for running Oracle WebLogic Server in the Azure Virtual Machines and Azure Kubernetes Service (AKS)
Universal Permissive License v1.0
8 stars 19 forks source link

Refactor maven structure of weblogic-azure #291

Closed backwind1233 closed 6 months ago

backwind1233 commented 6 months ago

Goal

Refactor the weblogic-azure code to reduce duplicated maven configuration codes.

Test

backwind1233 commented 6 months ago

Hello @galiacheng @edburns, please help review this PR.

backwind1233 commented 6 months ago

I 100% agree with the spirit and design of these changes. In addition, I think we need to make it more clear to the people who own this code, the Oracle engineers, why we are making these changes and exactly how they work.

We need to find the best balance between these two concerns: "too many comments so no-one will maintain them and they will become stale and misleading" "too few comments so that maintainers will need to spend a lot of time figuring out what it does, and they may get it wrong." I have put individual comments in the source files of the PR to guide you in making further commits to achieve that balance.

Thank you, I am very grateful for your thoughtful comments. @edburns

edburns commented 6 months ago

Hello @backwind1233 please put this PR back into Draft state while you apply the changes. When you are ready for another round of review from me, ask me and I'll review it. Then, when I advocate for merging, we can move it back out of Draft state.

Thanks,

Ed

edburns commented 6 months ago

Also, I want to get PR #290 merged first because this one impacts a feature in the offer.