oraclebase / vagrant

Vagrant Builds
https://oracle-base.com/
GNU General Public License v3.0
194 stars 170 forks source link

Tomcat compression="on" needs to be added to Connector UpgradeProtocol #21

Closed mark-lancaster closed 3 years ago

mark-lancaster commented 3 years ago

Hi Tim

In server.xml for your Vagrant VMs please add compression="on" to the UpgradeProtocol. It is not inherited from the Connector attributes. Tested in Tomcat 9.0.46

    <Connector port="8443" protocol="HTTP/1.1" SSLEnabled="true"
               maxThreads="250" scheme="https" secure="true"
               keystoreFile="###KEYSTORE_DIR###/keystore.jks"
               keystorePass="###KEYSTORE_PASSWORD###"
               clientAuth="false" sslProtocol="TLS" sslEnabledProtocols="TLSv1.2"
               URIEncoding="UTF-8"
               compression="on"
               noCompressionUserAgents="gozilla, traviata"
               compressableMimeType="text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json"
               >
      <UpgradeProtocol className="org.apache.coyote.http2.Http2Protocol" compression="on"/>
    </Connector>
oraclebase commented 3 years ago

Done. Thanks for the heads-up. :)

Cheers

Tim...