oraclesorg / oracles-contract

New version of POA Network consensus contracts is here: https://github.com/poanetwork/poa-network-consensus-contracts
MIT License
24 stars 8 forks source link

addValidator refactoring #18

Closed lorien closed 6 years ago

lorien commented 6 years ago

I suggest to split addValidator on two functions:

Also I suggest to move mining key data existence check into separate method. Something like:


function isMiningKeyDataExists(address miningKey) returns (bool) {
    bytes memory name = bytes(validator[miningKey].fullName);
    return name.length > 0;
}
vbaranov commented 6 years ago

See https://github.com/oraclesorg/oracles-contract/commit/1e7f00a6a81a72da0215ed3c2f863ae4823570e4 + https://github.com/oraclesorg/oracles-contract/commit/3a065ecdf31d2157dc3a501140edd1d36b206c0b