search

oraclesorg / oracles-contract

New version of POA Network consensus contracts is here: https://github.com/poanetwork/poa-network-consensus-contracts
MIT License
24 stars 8 forks source link

Some tests failed #26

Closed vbaranov closed 6 years ago

vbaranov commented 6 years ago

make testrpc make test

Instead invalid opcode 2 tests return VM Exception while processing transaction: revert

1) Contract: keysManager [all features] method addInitialKey is restricted for non-admin:

      AssertionError: expected promise to be rejected with an error including 'invalid opcode' but got 'VM Exception while processing transaction: revert'
      + expected - actual

      -VM Exception while processing transaction: revert
      +invalid opcode

  2) Contract: owned [all features] method protected by onlyOwner is restricted for non owner:

      AssertionError: expected promise to be rejected with an error including 'invalid opcode' but got 'VM Exception while processing transaction: revert'
      + expected - actual

      -VM Exception while processing transaction: revert
      +invalid opcode
lorien commented 6 years ago

I've pulled recent changes and run tests. They pass, I do not see errors.