search

oraclesorg / oracles-contract

New version of POA Network consensus contracts is here: https://github.com/poanetwork/poa-network-consensus-contracts
MIT License
24 stars 8 forks source link

Will we increase total number of licenses? #30

Closed vbaranov closed 6 years ago

vbaranov commented 6 years ago

For now, it is

int8 internal licensesLimit = 52;

@igorbarinov

igorbarinov commented 6 years ago

it's a limit for initial validators + all added?

vbaranov commented 6 years ago

yes: from ceremony (25) + from governance = 52

rstormsf commented 6 years ago

Solution: lets remove the limit. Rationale: we can't predict how many validators will be needed for mainnet

igorbarinov commented 6 years ago

Let's set initial keys equal to 12 to match whitepaper. Validators will add more validators using governance dapp.

vbaranov commented 6 years ago

Let's set initial keys equal to 12 to match whitepaper. Validators will add more validators using governance dapp.

Done

Solution: lets remove the limit. Rationale: we can't predict how many validators will be needed for mainnet

I agree with rationale, but doubt about solution. How about technical limit, let's say = 1000? IMO it is not a good idea to have dynamic sized array in solidity with possibility in contract to fill it with unlimited number of elements without any limits.

vbaranov commented 6 years ago

Tested that the technical limit is 2000. More validators in array will cause out of gas problem.