oraclesorg / oracles-contract

New version of POA Network consensus contracts is here: https://github.com/poanetwork/poa-network-consensus-contracts
MIT License
24 stars 8 forks source link

Problem: redundant code for payout key #60

Open rstormsf opened 6 years ago

rstormsf commented 6 years ago

https://github.com/oraclesorg/oracles-contract/blob/master/src/KeysStorage.sol#L108

Reason: There is no enforcement or validation how miner's will store his/her funds. The contract should only handle miner's & voting's keys to validate the input.

The oracles's script can and should be able to use any payout public keys.

Solution: Remove any code that handles payout logic for optimization

vbaranov commented 6 years ago

From where do you suggest transfer script will get payout address on validator mining node instead of getting it from contract? @rstormsf

rstormsf commented 6 years ago

the point is that payout key can be arbitrary address. A validator has to provide it during the deployment of the node. that's where it should get it from