search

oraichain / orai

Monolithic repository of everything Oraichain
Other
28 stars 19 forks source link

chore: set default node home to $HOME/.oraid #25

Closed albttx closed 2 months ago

albttx commented 1 year ago

Hello,

It's really annoying to have the NodeHome in $PWD/.oraid by default for multiple reasons.

For the docker images, i believe we might need to fix and set the home directory to /workspace or change the default location to /root/.oraid ?

ducphamle2 commented 1 year ago

Hello,

It's really annoying to have the NodeHome in $PWD/.oraid by default for multiple reasons.

  • Everytime you execute a oraid command, you'll create a new $PWD/.oraid
  • If you're in / default is //.oraid

For the docker images, I believe we might need to fix and set the home directory to /workspace or change the default location to /root/.oraid?

I believe we can get this updated in the next update version. The reason is that most docker image users have their .oraid/ located in /workspace. If we were to change the default home path to $HOME so suddenly, then the network would be come unstable.

We can firstly recommend the validators to manually change their data to $HOME first, and set a --home flag manually in their commands. Once most of them have applied the change, then we can create a minor update.

Also, the change is deterministic, so I believe the validators can update their binaries independently after the PR. What do you think?

albttx commented 1 year ago

Hello,

Yes, i think if in the next version we add in the docker image a --home /workspace/.oraid that would fix the issue. or just asks validators to move their home.

Another solution, IIRC, docker images use cosmovisor (that you named oraivaisor), that takes a $DAEMON_HOME var for that, so maybe if we just set ENV DAEMON_HOME=/workspace in the Dockerfile, that might fix the issue

ducphamle2 commented 1 year ago

Yea I agree. Let's keep this PR open so we can remember to add the update into the next version!