oraichain / wasmd

Basic cosmos-sdk app with web assembly smart contracts
Other
3 stars 9 forks source link

Upgrade cosmos-sdk v0.50 get error "tx must have at least one signer" when send tx with ethermint module #14

Open ledanghuy1811 opened 3 hours ago

ledanghuy1811 commented 3 hours ago

Context

Oraichain has a custom feature allowing user can mapping Oraichain address with EVM address.

This custom module allow user to execute tx in both Oraichain and EVM chain and asset of both chains will decrease or increase when executing tx on one chain and vice versa.

However, before run e2e-upgrade-test for chain to cosmos-sdk v0.50, we can send evm coin in the side of EVM normally, but after upgraded, when we try to send evm coin, the error like below show up:

Screenshot 2024-10-16 at 16 22 48

To Reproduce

Steps to reproduce the behavior:

  1. Clone this repository and checkout to this commit
  2. Run make build command
  3. Run ./scripts/e2e-upgrade.sh
  4. See error

Expected behavior

The error will show up and the process will stop.

Additional context

ledanghuy1811 commented 3 hours ago

The error is because in new cosmos-sdk app.toml file, it has new config max-txs for mempool and default is -1. It means txs is handles with no-op mempool.

Screenshot 2024-10-16 at 17 26 16

But our app.toml file does not have this config, it lead to txs will be handle with mempool because default max-txs is 0.

ledanghuy1811 commented 3 hours ago

So we decide to add max-txs = -1 config before we run e2e-upgrade chain to solve the problem.

Fixed in here