search

orangain / textlint-plugin-review

textlint plugin to lint Re:VIEW documents
https://www.npmjs.com/package/textlint-plugin-review
Other
13 stars 5 forks source link

Add Compliance test for textlint #3

Closed azu closed 8 years ago

azu commented 8 years ago

Hi, I'v added compliance-test for textlint.

textlint/textlint-ast-test is a test module that validate the AST.

So, I'v found missing raw of Document node and fixed it.

I'v re-defined TxtNode in detail and update document on textlint. Please see https://github.com/textlint/textlint/pull/170 for details.

orangain commented 8 years ago

@azu Thanks for the PR. I'm pleased with the re-definition of TxtNode. It will make it easy to create a new plugin for textlint.

I have a question. Is there any reason to use both test() and isTxtAST() in compliance-test.js? Reading the textlint-as-test's document, they have the same function though their interfaces are different. If they are the same, I think assert(isTxtAST(AST)); is better because it is more explicit.

azu commented 8 years ago

@orangain Thanks for suggestion. I fix it that only use assert(isTxtAST(AST));

orangain commented 8 years ago

Thanks! Merged and released v0.1.3.