Support inner broker with async service provisionning - Githubissues

orange-cloudfoundry / cf-ops-automation-broker

On demand dedicated services through COA concourse pipeline engine

4 stars 0 forks source link

Support inner broker with async service provisionning #364

Open gberche-orange opened 3 years ago

gberche-orange commented 3 years ago

Expected behavior

As a coab service broker author

in order to leverage off-the-shelf community brokers that only support async provisionning such as cloud-service-broker
I need COAB to delegate async provisioning calls (+ polling) to inner brokers

Observed behavior

COAB specifies async-supported=false in provisionning requests and does not issue last-operation calls

https://github.com/orange-cloudfoundry/cf-ops-automation-broker/blob/9b6a7a33881c9f8ab8d6f79358d204c5afed69fa/cf-ops-automation-broker-core/src/main/java/com/orange/oss/cloudfoundry/broker/opsautomation/ondemandbroker/pipeline/OsbProxyImpl.java#L258

COAB does not manage state in a database, it relies instead on OSB API support for service instance operations in which it stores its next step to execute after the coa deplyment completes. Support inner broker would require to either
- also track whether during each polling an inner service instance is currently in progress
  - However, OSB API does not provide support for modifying operations in the GET /v2/service_instances/:instance_id/last_operation response. This would likely require to introduce a cache/db for coab to maintain its state machine
- or to expect inner brokers would reject duplicate provisionning calls.
  - CSB seems to properly reject duplicate provisionning calls https://github.com/cloudfoundry-incubator/cloud-service-broker/blob/69241c8670f94ed2541f3fdb4dddb5b77756a487/brokerapi/brokers/service_broker.go#L103-L110
  - CSB seems to not reject duplicate update calls https://github.com/cloudfoundry-incubator/cloud-service-broker/blob/69241c8670f94ed2541f3fdb4dddb5b77756a487/brokerapi/brokers/service_broker.go#L579-L641 https://github.com/cloudfoundry-incubator/cloud-service-broker/blob/69241c8670f94ed2541f3fdb4dddb5b77756a487/pkg/providers/tf/provider.go#L76-L96 and https://github.com/cloudfoundry-incubator/cloud-service-broker/blob/69241c8670f94ed2541f3fdb4dddb5b77756a487/pkg/providers/tf/job_runner.go#L204-L237 https://github.com/cloudfoundry-incubator/cloud-service-broker/blob/69241c8670f94ed2541f3fdb4dddb5b77756a487/pkg/providers/tf/job_runner.go#L104-L118