search

orange-cloudfoundry / cf-ops-automation-broker

On demand dedicated services through COA concourse pipeline engine
4 stars 0 forks source link

Bump feign-okhttp from 11.6 to 11.8 #465

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps feign-okhttp from 11.6 to 11.8.

Release notes

Sourced from feign-okhttp's releases.

OpenFeign 11.8

What's Changed

New Contributors

Full Changelog: https://github.com/OpenFeign/feign/compare/11.7...11.8

OpenFeign 11.7

What's new in OpenFeign 11.7

This minor release includes: 🎁

Highlights: ⚡️

  • Get build compatible with jdk 16 (#1519)
  • [mock] verifyTimes with RequestKey parameter (#1517)
  • JDK 11 HttpClient async implement for AsyncFeign. (#1330)

Enhancements 🎉

  • Changing archuis-core scope to test (#1496)
  • Aggregate Micrometer "uri" label values under uri template (#1493)
  • SOAPEncoder: Add support to modify soap message manually (#1503)
  • set request factory in Google http client constructor (#1509)
  • Fixed flaky tests due to class.getMethods (#1525)

Security Updates 🔐

  • Many libraries upgrade to latest version (help wanted to list which ones)
  • Okhttp: CVE-2020-29582 due to old version of Okhttp (Squareup) (#1514)

Contributors

@​velo @​kdavisk6 @​mikrethor @​martinacat @​Laess3r

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
gberche-orange commented 2 years ago

@dependabot rebase

gberche-orange commented 2 years ago

Blocked by springboot 2.6 bump

Breaks with

org.opentest4j.AssertionFailedError: Unexpected exception type thrown ==> expected: <feign.FeignException> but was: <java.lang.NoClassDefFoundError>
    at com.orange.oss.cloudfoundry.broker.opsautomation.ondemandbroker.osbclient.OsbClientTest.feign_client_handles_server_500_response(OsbClientTest.java:332)
Caused by: java.lang.NoClassDefFoundError: feign/Request$ProtocolVersion

While coab dependabot/maven/io.github.openfeign-feign-okhttp-11.8 is at

      <dependency>
        <groupId>io.github.openfeign</groupId>
        <artifactId>feign-core</artifactId>
        <version>10.12</version>
      </dependency>

https://github.com/OpenFeign/feign/blob/10.12/pom.xml#L74 relies on ok http 4.6.0

While coab dependabot/maven/io.github.openfeign-feign-okhttp-11.8 is at okhttp 4.9.3

        <dependency>
            <groupId>com.squareup.okhttp3</groupId>
            <artifactId>okhttp</artifactId>
            <version>4.9.3</version>
        </dependency>

The feign bump is controlled spring-cloud-starter-openfeign and hence blocked by spring cloud bump

        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-openfeign</artifactId>
        </dependency>

Currently at the latest 2020.0.5 https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-2020.0-Release-Notes with Spring Cloud Openfeign 3.0.6

See more in https://github.com/orange-cloudfoundry/cf-ops-automation-broker/pull/455

gberche-orange commented 2 years ago

@dependabot recreate

dependabot[bot] commented 2 years ago

Looks like this PR has already been merged. If you've moved back to an older version of io.github.openfeign:feign-okhttp a new PR will be created next time Dependabot checks your dependencies.