search

orange-cloudfoundry / cf-ops-automation

a collaboration framework for operating cloudfoundry and services at scale
22 stars 6 forks source link

approve-and-delete-disabled-deployments should cancel associated bosh tasks #104

Open gberche-orange opened 6 years ago

gberche-orange commented 6 years ago

Currently, the delete lifecycle bindling deletes bosh deployments regardless of whether they have running associated bosh tasks. As a result, the delete sometimes fails with:

Task 56598 | 21:54:58 | Error: Failed to acquire lock for lock:deployment:cassandra_1d8ca879-8650-47c3-8098-9f3f89a098d0 uid: 4f49d55d-366d-4c05-85ec-7e9ada332eb7

Suggested fix: add pseudo code bosh tasks | xargs -n 1 bosh cancel-task would avoid such symptoms

Relevant pipeline:

https://github.com/orange-cloudfoundry/cf-ops-automation/blob/ab25536de3557fa28a3432e2a6e0e33c414c357c/concourse/pipelines/template/depls-pipeline.yml.erb#L320-L332

gberche-orange commented 6 years ago

Setting as P3 since this is low frequency