search

orange-cloudfoundry / osb-cmdb

A configuration management db for Open Service Broker API broker implementations
Apache License 2.0
14 stars 1 forks source link

capi release > 1.92 breaking change: Async service instance create/update is lacking metadata update + concurrent K8S handling break #65

Closed gberche-orange closed 3 years ago

gberche-orange commented 4 years ago

Expected behavior

Async service to be provisionned successfully when backing service broker succeeds including recording meta-data

Observed behavior

Async service provisioning succeeds but are missing meta-data

The following traces are seen in the logs 

   2020-09-11T12:59:44.58+0000 [APP/PROC/WEB/1] OUT 2020-09-11 12:59:44.584  INFO 11 --- [nio-8080-exec-8] c.o.o.o.s.OsbCmdbServiceInstance         : Inspecting exception caught org.cloudfoundry.client.v3
.ClientV3Exception: CF-AsyncServiceInstanceOperationInProgress(60016): An operation for service instance 6df55e7f-b909-4f37-8581-12ed4d750608 is in progress. for possible concurrent dupl while handling re
quest ServiceBrokerRequest{platformInstanceId='null', apiInfoLocation='api.redacted-domain.org/v2/info', originatingIdentity=Context{platform='cloudfoundry', properties={user_id=0d02117b-aa21-43e
2-b35e-8ad6f8223519}}', requestIdentity=653031cf-99b2-44c7-a86d-04bcd5f1ef5e}AsyncServiceBrokerRequest{asyncAccepted=true}AsyncParameterizedServiceInstanceRequest{parameters={}, context=Context{platform='
cloudfoundry', properties={spaceGuid=1a603476-a3a1-4c32-8021-d2a7b9b7c6b4, spaceName=smoke-tests, organizationName=osb-cmdb-brokered-services-org-client-0, instanceName=osb-cmdb-broker-0-smoketest-1599829
144, organizationGuid=c2169b61-9360-4d67-968c-575f3a10edf5}}}CreateServiceInstanceRequest{serviceDefinitionId='b0300e6e-8f93-4309-bdee-01099f644b97', planId='477aef10-2433-4c5f-8a7a-46489f04e2fa', organiz
ationGuid='c2169b61-9360-4d67-968c-575f3a10edf5', spaceGuid='1a603476-a3a1-4c32-8021-d2a7b9b7c6b4', serviceInstanceId='6df55e7f-b909-4f37-8581-12ed4d750608', maintenanceInfo='MaintenanceInfo{version='1.1.
0, description='osb-cmdb now propagates dashboard url (instant upgrade, no downtime)}'}

[...]

   2020-09-11T12:59:44.82+0000 [APP/PROC/WEB/1] OUT 2020-09-11 12:59:44.828  INFO 11 --- [nio-8080-exec-8] c.o.o.o.s.OsbCmdbServiceInstance         : Concurrent request is not incompatible and is still in
 progress success: 202

This is caused by https://github.com/cloudfoundry/capi-release/issues/183

Affected release

Reproduced on version 1.1.0

gberche-orange commented 3 years ago

fixed by capi in https://github.com/cloudfoundry/cloud_controller_ng/issues/1848 and https://github.com/cloudfoundry/cloud_controller_ng/issues/1847 https://github.com/cloudfoundry/cloud_controller_ng/issues/1842