TrustedDestination support introduced in 2.2.0 prevents credentials with FQDNs

[gberche-orange]

expected behavior

As a sec-group-broker operator

• in order to expose credentials with FQDNs
• I need sec-group-broker filter to properly support FQDNs as documented in https://github.com/orange-cloudfoundry/sec-group-broker-filter#when-are-credentials-fqdn-looked-up-when-are-asg-updated-if-dns-resolution-changes

observed behavior

• given a credential with content

credentials=
{
hostname=apps-internet-http-proxy.internal.paas, 
password=dont_use, 
port=3128, 
uri=http://apps-internet-http-proxy.internal.paas:3128, 
username=dont_use
}

• when a service binding is requested
• then the following exception is displayed

  
  .s.c.ServiceBrokerWebMvcExceptionHandler : Unknown exception handled: 
  java.lang.IllegalArgumentException: Invalid IP address : apps-internet-http-proxy.internal.paas
  at com.orange.cloud.servicebroker.filter.securitygroups.domain.IPAddress.validate(IPAddress.java:32) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.securitygroups.domain.ImmutableIPAddress.validate(ImmutableIPAddress.java:98) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.securitygroups.domain.ImmutableIPAddress.of(ImmutableIPAddress.java:94) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.securitygroups.domain.TrustedDestinationSpecification.isSatisfiedBy(TrustedDestinationSpecification.java:16) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.securitygroups.filter.CreateSecurityGroup.run(CreateSecurityGroup.java:144) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.securitygroups.filter.CreateSecurityGroup.run(CreateSecurityGroup.java:56) ~[classes/:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.core.filters.ServiceInstanceBindingFilterRunner.lambda$null$2(ServiceInstanceBindingFilterRunner.java:78) ~[service-broker-filter-core-2.4.0.RELEASE.jar:2.4.0.RELEASE]
  at java.util.ArrayList.forEach(ArrayList.java:1259) ~[na:1.8.0_265]
  at com.orange.cloud.servicebroker.filter.core.filters.ServiceInstanceBindingFilterRunner.lambda$postBind$3(ServiceInstanceBindingFilterRunner.java:78) ~[service-broker-filter-core-2.4.0.RELEASE.jar:2.4.0.RELEASE]
  at java.util.Optional.ifPresent(Optional.java:159) ~[na:1.8.0_265]
  at com.orange.cloud.servicebroker.filter.core.filters.ServiceInstanceBindingFilterRunner.postBind(ServiceInstanceBindingFilterRunner.java:78) ~[service-broker-filter-core-2.4.0.RELEASE.jar:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.core.service.ServiceInstanceBindingServiceProxy.postBinding(ServiceInstanceBindingServiceProxy.java:77) ~[service-broker-filter-core-2.4.0.RELEASE.jar:2.4.0.RELEASE]
  at com.orange.cloud.servicebroker.filter.core.service.ServiceInstanceBindingServiceProxy.createServiceInstanceBinding(ServiceInstanceBindingServiceProxy.java:62) ~[service-broker-filter-core-2.4.0.RELEASE.jar:2.4.0.RELEASE]
  at org.springframework.cloud.servicebroker.service.ServiceInstanceBindingEventService.createServiceInstanceBinding(ServiceInstanceBindingEventService.java:58) ~[spring-cloud-open-service-broker-core-3.1.2.RELEASE.jar:na]
  at org.springframework.cloud.servicebroker.controller.ServiceInstanceBindingController.lambda$createServiceInstanceBinding$7(ServiceInstanceBindingController.java:128) ~[spring-cloud-open-service-broker-core-3.1.2.RELEASE.jar:na]