orange-cloudfoundry / static-creds-broker

A CloudFoundry service broker to ease exposition of static credentials
Apache License 2.0
7 stars 1 forks source link

Add support for syslog_drain_url #28

Closed gberche-orange closed 7 years ago

gberche-orange commented 8 years ago

ServiceBroker may return syslog_drain_url in the binding response, see http://docs.cloudfoundry.org/services/api.html#binding-syslog-drain and more generally http://docs.cloudfoundry.org/services/app-log-streaming.html Currently, only credentials are returned and syslog_drain_url are never returned see https://github.com/orange-cloudfoundry/static-creds-broker/blob/master/src/main/java/com/orange/servicebroker/staticcreds/service/CredsServiceInstanceBindingService.java#L34

This would be exposed with additional fields at either the service or service-plan level:

SERVICES[{SERVICE_ID}]_SYSLOG_DRAIN_URL
SERVICES[{SERVICE_ID}]_PLANS[{PLAN_ID}]_SYSLOG_DRAIN_URL

In terms of implementation, this would mean calling the existing setter to affect the syslog drain: https://github.com/spring-cloud/spring-cloud-cloudfoundry-service-broker/blob/44910ec3452cba64e11553074dda6c60d916fef1/src/main/java/org/springframework/cloud/servicebroker/model/CreateServiceInstanceAppBindingResponse.java#L47-L50

/CC @poblin-orange