search

orange-cloudfoundry / terraform-provider-credhub

This terraform provider let you create and retrieve credentials from credhub
Apache License 2.0
8 stars 2 forks source link

Add test coverage #7

Open gberche-orange opened 6 years ago

gberche-orange commented 6 years ago

Likely including acceptance tests using the TF acceptance testing framework documented at https://github.com/hashicorp/terraform/blob/master/.github/CONTRIBUTING.md#writing-acceptance-tests, until this appears explictly into https://www.terraform.io/docs/extend/index.html

The CI environment might need to leverage BBL to span an up to date credhub server and access it see related doc

Alternatively, the CI environment could be shared with the one from https://github.com/mevansam/terraform-provider-cf. @mevansam would you be ok with this ?

ArthurHlt commented 6 years ago

Sure it needs acceptance test.

Spawning from bbl is maybe too much as it needs a postgres database + running credhub jar and maybe add uaa which is a just jar too.

ArthurHlt commented 6 years ago

Docker compose ready for acceptance test, see https://github.com/orange-cloudfoundry/credhub-docker