orangeadam3 / terra121

A Minecraft Terrain Generating Mod for Cubic Chunks 1.12.2. attempting to generate real terrain, biomes, and features on a 1:1 scale
MIT License
280 stars 41 forks source link

Terrain shifted #114

Open DavixDevelop opened 4 years ago

DavixDevelop commented 4 years ago

I tested this on both bteairoecean and the default projection. When teleporting to 46.221099, 15.266406, the water and the roads are placed correctly, but it seems like the terrain itself is shifted. For example, in the screenshot below, the river and the road is positioned on the left in the valley in real life, but here it's placed uphill. Another example at the same location. I checked the dem files itself and overlayed it with the default map in osm, and it's aligned correctly, so the dem files itself are correct.

taeko-chan commented 4 years ago

ok correct me if i'm wrong, but you're saying the river in the top picture is supposed to flow to the left of that hill and so is the road?

DavixDevelop commented 4 years ago

Yes. This is how it looks like in real life. The hill starts right at the edge of the road, like in the bottom picture on the left. Another example.

taeko-chan commented 4 years ago

the way the roads and rivers are generated is by estimating the height of the terrain at a given x and z (converted from the latitude and longitude from the OSM data) and placing it there. obviously that creates problems. for example, here. i'm not sure exactly what the problem is, but the mod owner (@orangeadam3) is working on a bug he calls grounding issues, and this may be covered by that, so i'll let you know when a fix for that comes out. if the problem persists afterwards, i'll see what i can do about it.

DavixDevelop commented 4 years ago

Yeah, I've seen the code. First, it builds the terrain, and then it places things like roads, rivers, trees, and other things. It's weird because they are placed at the right coordinates, but because of the wrong terrain elevation, everything becomes weird.