search

orangeadam3 / terra121

A Minecraft Terrain Generating Mod for Cubic Chunks 1.12.2. attempting to generate real terrain, biomes, and features on a 1:1 scale
MIT License
280 stars 41 forks source link

Hardcoded API string in io.github.terra121.dataset.OpenStreetMaps:quickRequest #132

Open AhiVT opened 4 years ago

AhiVT commented 4 years ago

This hardcoded API string will always cause failures for OSM data if kumi.systems is down, regardless of what is set in the server's configuration.

orangeadam3 commented 4 years ago

OVERPASS_INSTANCE is a dead variable. serverOverpass should be a variable string in the config menu

SmylerMC commented 4 years ago

It would be nice if serverOverpass was read when the urls are actually created and not when declaring the URL_PREFACE final variable, that would allow users to change the endpoint without restarting the game.

orangeadam3 commented 4 years ago

That's fair, if I remember ill add it in the next commit. Mabye an approach that chooses from a list to be implemented later.