orangeadam3 / terra121

A Minecraft Terrain Generating Mod for Cubic Chunks 1.12.2. attempting to generate real terrain, biomes, and features on a 1:1 scale
MIT License
282 stars 40 forks source link

Terra121 doesn't fire all generation events and CC API generator registry #33

Closed Barteks2x closed 4 years ago

Barteks2x commented 4 years ago

The following are not done

           MinecraftForge.EVENT_BUS.post(new PopulateCubeEvent.Pre(world, rand, pos.getX(), pos.getY(), pos.getZ(), false));
           // populator code
           MinecraftForge.EVENT_BUS.post(new PopulateCubeEvent.Post(world, rand, pos.getX(), pos.getY(), pos.getZ(), false));
            CubeGeneratorsRegistry.generateWorld(world, rand, pos, cubicBiome.getBiome()); }
orangeadam3 commented 4 years ago

I can do the bus events but can you explain what CubeGeneratorsRegistry.generateWorld is for?

orangeadam3 commented 4 years ago

Also I noticed you keep getting a lot of the same question about installing cc/cwg on curseforge, should we add some docs here about not using the download button.

Barteks2x commented 4 years ago

CubeGeneratorsRegistry.generateWorld generates things from mods registered as a cubic populator (equivalent to forge's IWorldGenerator).

As for info about downloading - I created a FAQ section in CC, but it may be useful to add it somewhere to terra121 too.

orangeadam3 commented 4 years ago

Oh ok that possibly explains a custom ore bug people were having earlier. Ill try to push tonight (aka like 5 hours) then