Only one notification is sent with duplicated adapters

orangecoding / fredy

:heart: Fredy - [F]ind [R]eal [E]states [D]amn Eas[y] - Fredy will constantly search for new listings on sites like Immoscout or Immowelt and send new results to you, so that you can focus on more important things in life ;)

http://www.orange-coding.net

MIT License

212 stars 54 forks source link

Only one notification is sent with duplicated adapters #19

Closed saschnet closed 3 years ago

saschnet commented 3 years ago

I have the use case that I want to send two emails to two different recipients within a single job.

Therefore, I added a second Mailjet Notification Adapter within the same job with the second recipient address: grafik

When new alerts show up, only a single notification within the same adapter type is sent and the other adapter ignored. Other adapters (here Console) are successfully triggered.

orangecoding commented 3 years ago

@saschnet This should now also be fixed, see https://github.com/orangecoding/fredy/commit/9726079f62deab6cd8cf91c70927721a70e3007c

By the way, Fredy is open source, I'd appreciate a pr with a potential fix if possible ;)

Thanks and sorry for the inconvenience.

saschnet commented 3 years ago

Thank yo for the super quick fix.

I definitely have in mind providing a PR next time. As I haven't worked with Nodejs so far, I thought making aware of a bug is better than nothing for the start.

orangecoding commented 3 years ago

@saschnet I absolutely appreciate you to create this bugticket, don't get me wrong. This is what open source is about. Be nice to each other, help and get help :)