orangecoding / fredy

:heart: Fredy - [F]ind [R]eal [E]states [D]amn Eas[y] - Fredy will constantly search for new listings on sites like Immoscout or Immowelt and send new results to you, so that you can focus on more important things in life ;)
http://www.orange-coding.net
MIT License
212 stars 54 forks source link

Allow editing provider and notification adapter settings #23

Closed carstenhag closed 3 years ago

carstenhag commented 3 years ago

Currently one can only create a providers/adapter and delete it, but it's not possible to edit them.

orangecoding commented 3 years ago

For notification adapter, it kinda makes sense as you have to type in the api keys etc, but for providers, I'm not so sure it makes sense.

In the end, you would go back to the page (immoscout for instance) copy the url and replace the current one. Removing the old provider and re-adding it is somehow the same effort no?

carstenhag commented 3 years ago

Sort of the same thing, but in my brain it goes like this: I want to edit the provider/the URL, deleting it and adding a new one feels weird.
So basically it's just an UX thing. You can leave it as is if you want to :)

orangecoding commented 3 years ago

@carstenhag notification adapter are now editable.

carstenhag commented 3 years ago

Yay, thanks!