search

orangecoding / fredy

:heart: Fredy - [F]ind [R]eal [E]states [D]amn Eas[y] - Fredy will constantly search for new listings on sites like Immoscout or Immowelt and send new results to you, so that you can focus on more important things in life ;)
http://www.orange-coding.net
MIT License
212 stars 54 forks source link

Define more than one mail recepient with MailJet and SendGrid #33

Closed stoyanovgeorge closed 2 years ago

stoyanovgeorge commented 2 years ago

I would like to add more than one mail recipient and tried the following separators between them:

None of them worked and if you have created one notification adapter of type A, Fredy doesn't allow you to create another one of the same type.

orangecoding commented 2 years ago

Interesting. At around 5k downloads, I never had such a request, even tho it makes sense. Will take a Look, thanks

orangecoding commented 2 years ago

@stoyanovgeorge I've created a pr for this. Can you please give it a review and a thumbs up if cool with you?

orangecoding commented 2 years ago

By the way, I accept pr's.. next time you can add this yourself. just saying ;)

stoyanovgeorge commented 2 years ago

I will test it tomorrow and update you here if there is a problem. Thanks a lot for your quick reaction. Cheers!

orangecoding commented 2 years ago

@stoyanovgeorge did you have a chance to test this?

stoyanovgeorge commented 2 years ago

I tried to install it yesterday on my RPI4B and create a docker container and run it from there, but the problem was that in the process I have somehow managed to crash my board so hard, that it didn't respond after the restart and I was not able to connect to it over SSH, so I have stopped. I will try to recover the board today and see if it would work. My problem was that in the past, the fredy stopped working after a while and I decided to give Docker containers a try.

stoyanovgeorge commented 2 years ago

it took me a while since my SD card on my RPI4B apparently failed and I needed to replace it, re-install the PI and install Fredy from scratch.

One annoyance is that changing settings requires a restart and I don't know of an easy way to perform this restart. And more than once it was not accepting my changes.