orangecoding / fredy

:heart: Fredy - [F]ind [R]eal [E]states [D]amn Eas[y] - Fredy will constantly search for new listings on sites like Immoscout or Immowelt and send new results to you, so that you can focus on more important things in life ;)
http://www.orange-coding.net
MIT License
212 stars 54 forks source link

Refactor Docker build and automatically push images #41

Closed joschi closed 2 years ago

joschi commented 2 years ago

This change set does two distinct things:

As a result, the Docker image is ~200 MiB smaller than before:

orangecoding/fredy          latest               5f93286a4e15   4 minutes ago    514MB
ghcr.io/joschi/fredy        pr-2                 3493253bc074   11 minutes ago   311MB

Demo repository: https://github.com/joschi/fredy/pkgs/container/fredy

GitHub Container repository for Fredy

Demo output from https://github.com/joschi/fredy/pull/2: logs_2.zip

References:

orangecoding commented 2 years ago

Looks awesome. Thanks!

orangecoding commented 2 years ago

@joschi quick question, there's a docker section in the readme. I assume this has to be changed as well no?

joschi commented 2 years ago

@orangecoding All of these commands are still working: https://github.com/orangecoding/fredy/blob/2764b2b77651a43e2653ae5c06a7e09ed13c9303/README.md#L84-L97

The only thing we could add is the availability of the automatically built Docker image in the GitHub container registry: https://github.com/orangecoding/fredy/pkgs/container/fredy