Couple of straightforward, hopefully useful, adjustments:
mpcf_maths moved from mpc.c to tests/core.c, because:
seems like a very specific function that should not be included in main library object
it is only used in the mentioned test
adjusted the grammar in test_maths to switch the set of operators for Term and Expr such that they follow the standard convention regarding precedence, in fact, now with the grammar in the test consistent with the similar grammar definition in the README.
In short, no critical adjustments, well, perhaps except for 1. in case some client code out there already happens to rely on mpcf_maths ...
If this can be merged (or some of the above committed directly by any maintainers), great! if not, totally fine, too. Thanks.
orangeduck
commented
1 year ago
Couple of straightforward, hopefully useful, adjustments:
mpcf_mathsmoved frommpc.ctotests/core.c, because:test_mathsto switch the set of operators forTermandExprsuch that they follow the standard convention regarding precedence, in fact, now with the grammar in the test consistent with the similar grammar definition in the README.In short, no critical adjustments, well, perhaps except for 1. in case some client code out there already happens to rely on
mpcf_maths...If this can be merged (or some of the above committed directly by any maintainers), great! if not, totally fine, too. Thanks.