search

orangeglo / everdrive-gba-editor

Build a custom theme for your EverDrive GBA!
https://orangeglo.github.io/everdrive-gba-editor/
GNU General Public License v3.0
12 stars 1 forks source link

Palette is being reset by diagnostics #1

Closed pyth27 closed 11 months ago

pyth27 commented 3 years ago

When you run diagnostics the palette is reset from a different part of the code (somewhere around 0x67F0). Not sure if this is worth fixing but I wanted to let you know. :)

epbarger commented 3 years ago

I was wondering if anyone would notice this!

Yeah I'm aware of the other palette locations. The reason I decided not to implement this is it appears that the FPGA (or some other process I don't understand) plays some role in the diagnostics process, and actually changes a couple of the palette entries to show the red ❌ and the green ✔️. I know the color green gets inserted into palette 0x5E. The problem with this is if you are overriding the palette that uses 0x5E (highlighted text I think?) to set the background or something, when you return from diagnostics there is no code to make that palette black again.

So I figured just having the theme completely reset was preferred to potentially having a half-applied theme... especially since running diagnostics isn't something that you do often

pyth27 commented 3 years ago

Yeah I figured it would be an issue for the overriden palettes. I find it strange that there would be two slightly different methods for setting up the palettes...

You're probably right about leaving it like it is, most people won't even notice.